[Refactor] Support handleAddFolder in TreeExplorer #3101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts the custom logic previously in node bookmark tree to generic TreeExplorer component so it can be reused for workflow tree.
Previous we were creating a folder with placeholder name first, then enter the rename mode, however, this can be inefficient, as it involves 2 writes, one for creation and one for rename. This PR optimizes this process to be creating a temp node for user to enter name first, then directly create the folder with that given name.
┆Issue is synchronized with this Notion page by Unito