feat: Adding VC Redistributable #354
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinjhuang
reviewed
Dec 11, 2024
Comment on lines
+22
to
+24
|
|
||
| // Download Visual C Redistributable depedency for Pytorch (-L sets to follow redirects) into %TEMP% (will be picked up by installer.nsh) | ||
| const result3 = spawnSync('curl', ['-s', '-L', 'https://aka.ms/vs/16/release/vc_redist.x64.exe', '-o', '%TEMP%/vc_redist.x64.exe'],{shell:true,stdio: 'ignore'}).toString(); |
There was a problem hiding this comment.
Question on this, what does the TEMP directory mean here?
Ideally I want to move most things outside of beforeInstall because ToDesktop logs are not very reliable. For example for uv we pre-download everything on Github actions and upload everything to ToDestkop.
There was a problem hiding this comment.
Since I'm including the redistributable in the installer I need to point NSIS file to location where it can grab it; unfortunately the location of installer build is ephemeral and I need full path so I opted to use official Windows temporary directory to download the installer into (see beforeInstall.js parameters '-o', '%TEMP%/vc_redist.x64.exe') and then NSIS can pick it up from there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build: https://app.todesktop.com/apps/241012ess7yxs0e/builds/241130b4y13czmg
┆Issue is synchronized with this Notion page by Unito