Fix options not working for Core #2491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ne0rrmatrix
added
the
area/core
TheCodeTraveler
previously approved these changes
Feb 4, 2025
pictos
previously approved these changes
Feb 4, 2025
…ptionCompleted` to allowunit tests confirm that we initialized the AndroidDialogFragmentService
TheCodeTraveler
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Thanks again James! Just FYI - I added some Unit Tests to help us ensure we don't ever accidentally flip the order of operations again.
In other words, these unit tests ensure that we always invoke options?.Invoke(new Options(builder)); before we invoke builder.UseMauiCommunityToolkitCore(null);.
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Currently you cannot opt out of using new functionality for dialogue fragments on android. Setting the option to do so does not work with core. This PR fixes that issue by placing setting options earlier in build order.
Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information
This will allow ppl to opt out of using the new dialogue fragment in recent PR. Atm if you try to navigate to any page in sample app the app crashes to android desktop. This PR will fix that issue by allowing you to opt out. Current the opt out is not working. This PR addresses that issue only. It fixes options so that they work by placing options above core in build order.