Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XamlC warning for DrawingViewModel and MVVMTK warning SpeechToTextPage #2513

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

ne0rrmatrix
Copy link
Contributor

  • Bug fix

Description of Change

Add x:DataType to ItemDisplayBinding for Picker in SpeechToTextPage.
Fix ObservableProperty in DrawingViewModel.

Linked Issues

  • Fixes #

PR Checklist

  • Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls

Additional information

This fixes two warnings: XamlC warning XC0022, and MVVMTK0045 warning. This may fix some issues that have yet to be reported.

pictos
pictos previously approved these changes Feb 11, 2025
@TheCodeTraveler TheCodeTraveler merged commit d7ea78f into CommunityToolkit:main Feb 11, 2025
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants