Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: information page of specific club & autoclean HTML <script> <style> elements #494

Merged
merged 38 commits into from
Mar 2, 2024

Conversation

at-wr
Copy link
Contributor

@at-wr at-wr commented Mar 2, 2024

This PR added a new feature which includes a new page of displaying some of the details of a specific club after clicking the button of a specific club in /cas/clubs.
Though it has introduced a new page, however the style needs to be improved and more information is required in the future PRs.

Related Issue: #485

Copy link

netlify bot commented Mar 2, 2024

Deploy Preview for computerization-enspire-next ready!

Name Link
🔨 Latest commit b8e3227
🔍 Latest deploy log https://app.netlify.com/sites/computerization-enspire-next/deploys/65e346bf84ee270009fa4c09
😎 Deploy Preview https://deploy-preview-494--computerization-enspire-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@at-wr
Copy link
Contributor Author

at-wr commented Mar 2, 2024

Please don't merge this PR before I fixed the Linter issue

@at-wr
Copy link
Contributor Author

at-wr commented Mar 2, 2024

Please don't merge this PR before I fixed the Linter issue

Linter issue fixed

components/custom/club-card.vue Outdated Show resolved Hide resolved
pages/clubs/[id].vue Outdated Show resolved Hide resolved
pages/clubs/[id].vue Outdated Show resolved Hide resolved
pages/clubs/[id].vue Outdated Show resolved Hide resolved
pages/clubs/[id].vue Outdated Show resolved Hide resolved
@at-wr at-wr changed the title feat: detail information of specific club feat: detail information of specific club & autoclean HTML <script> <style> elements Mar 2, 2024
@at-wr
Copy link
Contributor Author

at-wr commented Mar 2, 2024

@qwerzl The requests have been fullfilled

@at-wr at-wr force-pushed the next branch 3 times, most recently from 32d18a2 to 312efe0 Compare March 2, 2024 10:36
@at-wr at-wr changed the title feat: detail information of specific club & autoclean HTML <script> <style> elements feat: information page of specific club & autoclean HTML <script> <style> elements Mar 2, 2024
@at-wr
Copy link
Contributor Author

at-wr commented Mar 2, 2024

I think it looks great rn

@at-wr at-wr requested a review from qwerzl March 2, 2024 10:55
Copy link
Collaborator

@qwerzl qwerzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. These are the final changes requested before I merge it.

components/custom/cleanHTML.d.ts Outdated Show resolved Hide resolved
pages/clubs/[id].vue Outdated Show resolved Hide resolved
pages/clubs/[id].vue Outdated Show resolved Hide resolved
pages/clubs/[id].vue Outdated Show resolved Hide resolved
pages/clubs/[id].vue Outdated Show resolved Hide resolved
pages/clubs/[id].vue Outdated Show resolved Hide resolved
@at-wr at-wr requested a review from qwerzl March 2, 2024 14:22
@qwerzl qwerzl merged commit 9e0aab8 into Computerization:next Mar 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants