rename to_array -> to_xy_arrays - fix dataset/numpy transitions #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
PeterDSteinberg
commented
Nov 10, 2017
| dsets = [xr.Dataset(x) for x in Xs] | ||
| np_arrs = [x.to_features().features.values for x in Xs] | ||
| dfs = [pd.DataFrame(x.to_features().features.values) for x in Xs] | ||
| choices = { |
There was a problem hiding this comment.
Note here we eventually (2018) want to test eventually any acceptable X or y data structures when to_xy_arrays is used as a standalone function, e.g. pandas, numpy, dask, DataArray/Dataset/MLDataset. The test is a parameterized one set up for that, but currently is only testing MLDataset X and numpy y.
This was referenced Nov 10, 2017
|
Created #47 (deferring the TODO list above) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MLDataset.to_array. That was not the best name for the function because it returns anX,ytuple. Now the function isxarray_filters.reshape.to_xy_arraysand it can be called as a standalone function or aMLDatasetmethod.TODO:
to_xy_arraysthat check a number of different possible data types forXandy(see data structures list here - Custom estimators / sklearn / dask and data structure flexibility checklist elm#202)