Run tests on Travis CI #1043
Open
Run tests on Travis CI #1043
+42
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danzen
reviewed
Mar 13, 2020
|
|
||
|
|
||
| describe("Deprecated Functions", function(done) { |
There was a problem hiding this comment.
In this case... Nothing. Which is why I removed it.
The version of jasmine that I installed gave errors that one of these functions didn't actually accept any arguments... I think it was the done callback in the describe test function argument.
Usually it is intended as a callback for asynchronous tests to end.
https://jasmine.github.io/tutorials/async
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes get travis up and running.
There are a couple of test groups disabled. Any help to figure out the issues with them is appreciated.
Here you can see the first pass: https://travis-ci.org/jedateach/EaselJS/builds/661221048