V Rising Add API Port #806
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Greelan
reviewed
May 27, 2024
|
I don't expect it to work on existing ones, no. I mentioned that in the development channel. |
|
Won't it break existing instances where someone is trying to configure it manually? Because it will always overwrite what they have included |
|
This is a very undocumented feature of V Rising. So it will be extremely minimal and can be addressed on a case by case. |
|
I'm going to have to do some thought into this one. Might have to wait until Port refresh logic is hashed out. It doesn't "break" the game server fully, but it does remove the line from the config since it's blank. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the port for the API to function on.