Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Seven days to die to 1.0 config #919

Closed
wants to merge 16 commits into from

Conversation

Xentraxx
Copy link

@Xentraxx Xentraxx commented Aug 3, 2024

Tested and working.

@Greelan
Copy link
Collaborator

Greelan commented Aug 7, 2024

Really needed to make all the unnecessary whitespace changes? Lol

@Xentraxx
Copy link
Author

Xentraxx commented Aug 7, 2024

Really needed to make all the unnecessary whitespace changes? Lol

VS Code auto formatting goes brr

@Xentraxx
Copy link
Author

@Greelan I think this Template is kind of a mess because of all the different versions it tries to handle.
I believe it's quite confusing. Like which setting to use for which version.
What do you think about creating a completely new template "Seven days to die" and renaming the other one to something along the lines "Seven days to die pre-release", to have a new start and a fresh and tidy template?

@IceOfWraith
Copy link
Collaborator

Rather than that I think it'd be better to just put the settings into a different subcategory.

@PhonicUK
Copy link
Contributor

I've got a pending PR for the new subcatetories, but I don't want this PR accepted with the formatting changes showing it as "Whole files removed/while files added" because it makes it impossible to review the changes.

@IceOfWraith
Copy link
Collaborator

If you can fix the spacing to 4 spaces in the JSON files I'll review this one. As is, it's too messy and doesn't match the formatting of others. There's a setting in VS that adjusts this.

@Xentraxx
Copy link
Author

I tried, but even though I changed the settings in VS code and the files look fine for me, VS code does not recognize this change as a change of the file, so apparently I can't save it.

@Greelan
Copy link
Collaborator

Greelan commented Oct 19, 2024

@IceOfWraith I have included some spacing fixes that should make it easier to review

@IceOfWraith
Copy link
Collaborator

Thank you! I'll look over it.

@Greelan
Copy link
Collaborator

Greelan commented Oct 19, 2024

Tho now there are conflicts due to the previous reconfiguration of the settings categories/subcategories.

Might be easier for the OP to start over tbh

@Greelan Greelan closed this Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants