Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve file extensions #963

Closed
wants to merge 2 commits into from

Conversation

Bluscream
Copy link

@Bluscream Bluscream commented Aug 17, 2024

Template file extensions were always kind of weird, and i know they're arbitrary, but it just makes more sense to follow some pattern, thats why the whole *config.json and *metaconfig.json stuff happened in the first place. However, the current way without any delimiter, makes it harder to programmatically go over the different config types (*metaconfig.json also contains *config.json, y know) and it's generally just harder to read when you look over a repo and see this
librewolf_DtkdTIP1Fe

I would suggest; for the future atleast, you enforce such a naming scheme for Pull Requests that want to be merged into the official template repo

@Greelan Greelan marked this pull request as draft August 20, 2024 12:13
@IceOfWraith
Copy link
Collaborator

I'm closing this since it would be a breaking change as we found out. A fix has been put in to address it, but old versions of AMP before the fix would error with these changes.

The plan is to combine templates into one JSON file in the near future which would overcome this problem as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants