Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ui for wallet ransfer #400

Open
wants to merge 44 commits into
base: develop
Choose a base branch
from
Open

Conversation

Ishaan28malik
Copy link
Contributor

Wallet Transfer flow added

Copy link

changeset-bot bot commented Feb 19, 2024

🦋 Changeset detected

Latest commit: 95acff7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@cypherock/cysync-core Patch
@cypherock/cysync-ui Patch
@cypherock/cysync-desktop Patch
@cypherock/cysync-desktop-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Ishaan28malik Ishaan28malik self-assigned this Mar 18, 2024
@Ishaan28malik Ishaan28malik changed the title feat: wallet ransfer feat: ui for wallet ransfer Apr 1, 2024
Copy link
Collaborator

@irshadjsr21 irshadjsr21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Alignment issues on Lost Device => Tap any of the 4 old X1 Cards below the X1 Vault. Also the on other dialogs with similar UI.
    image

  2. New screens needs to added after Lost Device and 2 Cards => 3.1 (On Figma). Contact Akshit regarding this.

  3. Incorrect image in Lost Device and 2 Cards => From the Main Menu of your X1 Vault, click "Settings"
    image

  4. Incorrect image in Lost Device and 2 Cards => Click "Restore wallets from cards" on your X1 Vault

  5. New screens needs to added after Lost Device and 2 Cards => 18.1 (On Figma). Contact Akshit regarding this.

  6. Changes might be needed on Figma after Lost Device and 2 Cards => 20.1 (On Figma). Contact Akshit regarding this.

  7. Spacing and arrows are different from Figma design
    image

  8. New screens needs to added after Lost 2 Cards => 7.1 (On Figma). Contact Akshit regarding this.

  9. Changes might be needed on Figma after Lost 2 Cards => 9.1 (On Figma). Contact Akshit regarding this.

  10. Spacing between arrow buttons is 16px on figma
    image

@Ishaan28malik Ishaan28malik requested a review from irshadjsr21 May 6, 2024 19:28
Copy link
Collaborator

@irshadjsr21 irshadjsr21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Image is different on Lost Device => 4.2 (Check on figma)
  2. On Lost Device last screen, the last milestone text should be gold
    image
  3. Image is different on screen Lost Device => 7.1. Also screen 7.1 and 13.1 has same text but different images. Confirm with Akshit which one is correct.
  4. Image is different on screen Lost Device => 14.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants