WIP Set tile id in map node

[SimplyLiz]

wip...

Remaining tasks:

• Clicking on water crashes game (empty tile ID) - initial m_originCoordinate value wasn't part of the move constructor
• Buildings can be placed multiple times
• Check multi tiles if placement is allowed
• Serialize origin coords

[Mograbi]

@SimplyLiz why removed the const ?
it's mainly meant for checking and it makes sense that it will be const

[SimplyLiz]

@SimplyLiz why removed the const ?
it's mainly meant for checking and it makes sense that it will be const

Because I need to use getMapNode instead of direct access and this must be a reference and I didn’t want to introduce a new function that does absolutely the same but is const

[Mograbi]

@SimplyLiz why removed the const ?
it's mainly meant for checking and it makes sense that it will be const

Because I need to use getMapNode instead of direct access and this must be a reference and I didn’t want to introduce a new function that does absolutely the same but is const

if it's exactly the same why not use const then ? didn't understand

[SimplyLiz]

@SimplyLiz why removed the const ?
it's mainly meant for checking and it makes sense that it will be const

Because I need to use getMapNode instead of direct access and this must be a reference and I didn’t want to introduce a new function that does absolutely the same but is const

if it's exactly the same why not use const then ? didn't understand

Because in a lot of cases we’ll need to Manipulate the mapnode objects. And in some we don’t which would need an exact duplicate of the getNode function but being const

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
77 Code Smells

40.7% Coverage
0.0% Duplication

[iaGuoZhi]

Hi! @SimplyLiz , Can I work on thie pr now? I want to fix this problem: #892.