Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build push a docker image to dockerhub on release #336

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

charalamm
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.90%. Comparing base (f507b4a) to head (5166f12).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #336   +/-   ##
=======================================
  Coverage   97.90%   97.90%           
=======================================
  Files          54       54           
  Lines        2389     2389           
  Branches      487      487           
=======================================
  Hits         2339     2339           
  Misses         34       34           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dionhaefner
Copy link
Collaborator

Awesome. Did you test this workflow somewhere @charalamm? (No is fine, I'd just like to know)

@charalamm
Copy link
Collaborator Author

charalamm commented Mar 29, 2024

@dionhaefner I have not tested it with the release. I tested it only when pushing on a branch and without the commit tag. Now that I am thinking about it I could test it in a throwaway repo. I will do that and then we can merge I guess.

@dionhaefner
Copy link
Collaborator

We could also merge this and do a post-release to test the deployment. Not quite as elegant but if it saves you work I'd be up for it.

@charalamm
Copy link
Collaborator Author

Hello @dionhaefner I have tested it in separate repo and it works and uses the release tag as the docker image tag. It also updates the latest tag image. I am merging if that is ok

Tests are failing for irrelevant reasons as far as I can see

@dionhaefner
Copy link
Collaborator

Sounds great, thanks @charalamm !

@charalamm charalamm merged commit 018f963 into main May 3, 2024
3 of 7 checks passed
@charalamm charalamm deleted the Image-CI branch May 3, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants