Photrim has been refactored to be callable; old Makefile tests have been converted to gtests and removed. #5582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tests have been converted to gtests and removed. Addresses DOI-USGS#5581.
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5582". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5582". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
acpaquette
pushed a commit
to acpaquette/ISIS3
that referenced
this pull request
Sep 11, 2024
…een converted to gtests and removed. (DOI-USGS#5582) * Photrim has been converted to a callable app. Corresponding Makefile tests have been converted to gtests and removed. Addresses DOI-USGS#5581. * Tweaks to FunctionalTestsPhotrim.cpp. Addresses DOI-USGS#5581.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The photrim application has been refactored to be callable. Makefile tests have been converted to gtests. Makefile tests have been removed.
Related Issue
#5581
How Has This Been Validated?
ctest suite results...
ctest -R FunctionalTestsPhotrim --output-on-failure
Test project /Users/kledmundson/ISISDev/photrim/Jul222024/ISIS3/build
Start 1492: DefaultCube.FunctionalTestsPhotrimBase
1/5 Test #1492: DefaultCube.FunctionalTestsPhotrimBase ........ Passed 1.56 sec
Start 1493: DefaultCube.FunctionalTestsPhotrimEmission
2/5 Test #1493: DefaultCube.FunctionalTestsPhotrimEmission .... Passed 1.56 sec
Start 1494: DefaultCube.FunctionalTestsPhotrimPhase
3/5 Test #1494: DefaultCube.FunctionalTestsPhotrimPhase ....... Passed 1.56 sec
Start 1495: DefaultCube.FunctionalTestsPhotrimIncidence
4/5 Test #1495: DefaultCube.FunctionalTestsPhotrimIncidence ... Passed 1.56 sec
Start 1496: DefaultCube.FunctionalTestsPhotrimUseDEM
5/5 Test #1496: DefaultCube.FunctionalTestsPhotrimUseDEM ...... Passed 1.55 sec
100% tests passed, 0 tests failed out of 5
Total Test time (real) = 7.98 sec
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: