-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor of the pixel2map application and add geospatial vector file output #5606
base: dev
Are you sure you want to change the base?
Conversation
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5606". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
The following tests are failing for this PR:
|
@@ -185,7 +185,7 @@ namespace Isis { | |||
projCubeLabel >> projLabel; | |||
|
|||
testCube = new Cube(); | |||
testCube->fromIsd(tempDir.path() + "/default.cub", label, isd, "rw"); | |||
testCube->fromIsd("tempDir.path() + default.cub", label, isd, "rw"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be the cause for the majority of the test failures since they all use the DefaultCube fixture.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@afrigeri This is still an issue and is causing a bunch of tests to fail. Can the change get reverted?
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5606". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5606". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5606". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
@afrigeri is this PR ready for a review? I am seeing compile errors on our test build. |
…ed during code cleanup)
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5606". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
Compile error should be fixed with aebfea5 |
This PR introduces a refactored pixel2map ISIS application and adds the option to generate a geospatial vector file.
The output (specified with TOVECT) will replicate the ISIS output cube using a specialized common vector format for geospatial applications. The vector format is a CSV ASCII file with a virtual (VRT) sidecar XML metadata file supported by the GDAL library. The output will be in unprojected, spherical coordinates (degrees) and provide the Coordinate Reference System (CRS) metadata of the planetary body compatible with the Open GIS Consortium (OGC) standards (IAU namespace).
The vector file can be handled by several geospatial tools and the most diffused GIS software.
Description
pixel2map, following the Isis developed guide, required a refactoring which required:
Changes to the library:
Changes to the app:
Related Issue
The proposed updates/changes is at #5604
Development-related Issues
Validation
Left the pre-existing old test structure with pixel2map test, and introduced new gtest for this specific update:
App test
added testing on the ASCII output file (had to use MroCtxCube, as the DefaultCube resulted in Null data when test is called from ctest - see above).
Unit test
added a new unit test validating the new Vectorize function by testing vector geometry integrity.