Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALE driver verification script addition #584

Merged
merged 27 commits into from
Mar 6, 2024

Conversation

antonhibl
Copy link
Contributor

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

This adds a script for driver verification wherein a image is run through both ALE and ISIS and then compared to see how different ALE drivers compare to ISIS' spiceinit in order to better compare how spice data is utilized through both for image ingestion. An example of it's usage is as follows:

python3 driver_verification.py ClementineIsisLabelNaifSpiceDriver LUA3107H.161.clem.cub

Output will look similar to the following:

Group = Kernels
  NaifFrameCode             = -40021
  LeapSecond                = $base/kernels/lsk/naif0012.tls
  TargetAttitudeShape       = ($base/kernels/pck/pck00009.tpc,
                               $base/kernels/pck/lunar_de403_1950-2199_pa.bpc,
                               $base/kernels/fk/lunarMeanEarth001.tf)
  TargetPosition            = $base/kernels/spk/de430.bsp
  InstrumentPointing        = ($Clementine1/kernels/ck/clem_2mn.bck,
                               $Clementine1/kernels/ck/clem_5sc.bck,
                               $clementine1/kernels/fk/clem_v12.tf)
  Instrument                = $Clementine1/kernels/ik/clem_uvvis_beta_ik_v04.-
                              ti
  SpacecraftClock           = $Clementine1/kernels/sclk/dspse002.tsc
  InstrumentPosition        = $Clementine1/kernels/spk/SPKMERGE_940219_940504-
                              _CLEMV001b.bsp
  InstrumentAddendum        = $Clementine1/kernels/iak/uvvisAddendum004.ti
  ShapeModel                = $base/dems/ldem_128ppd_Mar2011_clon180_radius_p-
                              ad.cub
  InstrumentPositionQuality = Reconstructed
  InstrumentPointingQuality = Reconstructed
  CameraVersion             = 1
  Source                    = isis
End_Group
This function(PvlObject::addLogGroup) will be depreciated in ISIS3 v9.0 in favor of Application::appendLogGroup
Group = Kernels
  NaifFrameCode             = -40021
  LeapSecond                = $base/kernels/lsk/naif0012.tls
  TargetAttitudeShape       = ($base/kernels/pck/pck00009.tpc,
                               $base/kernels/pck/lunar_de403_1950-2199_pa.bpc,
                               $base/kernels/fk/lunarMeanEarth001.tf)
  TargetPosition            = $base/kernels/spk/de430.bsp
  InstrumentPointing        = ($Clementine1/kernels/ck/clem_2mn.bck,
                               $Clementine1/kernels/ck/clem_5sc.bck,
                               $clementine1/kernels/fk/clem_v12.tf)
  Instrument                = $Clementine1/kernels/ik/clem_uvvis_beta_ik_v04.-
                              ti
  SpacecraftClock           = $Clementine1/kernels/sclk/dspse002.tsc
  InstrumentPosition        = $Clementine1/kernels/spk/SPKMERGE_940219_940504-
                              _CLEMV001b.bsp
  InstrumentAddendum        = $Clementine1/kernels/iak/uvvisAddendum004.ti
  ShapeModel                = $base/dems/ldem_128ppd_Mar2011_clon180_radius_p-
                              ad.cub
  InstrumentPositionQuality = Reconstructed
  InstrumentPointingQuality = Reconstructed
  CameraVersion             = 1
  Source                    = ale
End_Group
This function(PvlObject::addLogGroup) will be depreciated in ISIS3 v9.0 in favor of Application::appendLogGroup
1 [2.32830644e-10 2.32830644e-10 0.00000000e+00] [2.32830644e-10 2.32830644e-10 0.00000000e+00]
1 [ 1.13686838e-13  2.27373675e-13 -6.82121026e-13] [ 1.13686838e-13  2.27373675e-13 -6.82121026e-13]
1 [ 6.10351562e-05  2.28881836e-05 -3.81469727e-06] [ 6.10351562e-05  2.28881836e-05 -3.81469727e-06]
1 [ 2.91038305e-11 -1.16415322e-10  4.87716534e-11] [ 2.91038305e-11 -1.16415322e-10  4.87716534e-11]
1 [ 2.22044605e-16  2.77555756e-17 -1.11022302e-16  0.00000000e+00] [ 2.22044605e-16  2.77555756e-17 -1.11022302e-16  0.00000000e+00]
1 [-5.42101086e-20 -2.16840434e-19  2.71050543e-20] [-5.42101086e-20 -2.16840434e-19  2.71050543e-20]
1 [ 0.00000000e+00 -2.77555756e-17 -6.93889390e-18  2.77555756e-17] [ 0.00000000e+00 -2.77555756e-17 -6.93889390e-18  2.77555756e-17]
1 [-5.29395592e-23 -2.11758237e-22  4.23516474e-22] [-5.29395592e-23 -2.11758237e-22  4.23516474e-22]

@antonhibl antonhibl added the enhancement New feature or request label Jan 8, 2024
@antonhibl antonhibl self-assigned this Jan 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024

Codecov Report

Attention: 141 lines in your changes are missing coverage. Please review.

Comparison is base (775ff21) 15.82% compared to head (ec29db7) 15.47%.

Files Patch % Lines
ale/driver_verification.py 0.00% 141 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #584      +/-   ##
==========================================
- Coverage   15.82%   15.47%   -0.35%     
==========================================
  Files          56       57       +1     
  Lines        6283     6424     +141     
==========================================
  Hits          994      994              
- Misses       5289     5430     +141     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antonhibl antonhibl mentioned this pull request Jan 11, 2024
1 task
antonhibl and others added 3 commits January 11, 2024 15:00
…ested and run against to find one that works.

there is a small note to make about the use of pvl.loads() in this script. I commented out 2 lines using that function and had to change to variable names in the subsequent lines as this pvl.loads() function won't work as expected until DOI-USGS#587 is merged to apply the bug fix to that method; that fix will allow ale.loads() to read in PVLObjects, currently because the lines are commented ale.loads() just reads in the image files themselves which still works but requires more overhead in ale.loads().
@antonhibl antonhibl mentioned this pull request Jan 17, 2024
1 task
Copy link
Collaborator

@acpaquette acpaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, couple of things to address then this can get merged

ale/driver_verification.py Outdated Show resolved Hide resolved
ale/driver_verification.py Outdated Show resolved Hide resolved
@antonhibl antonhibl merged commit 4e89736 into DOI-USGS:main Mar 6, 2024
13 checks passed
@antonhibl antonhibl deleted the spice-verification branch March 6, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants