Updates to Kaguya Driver #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
April 4, 2019 09:49
acpaquette
reviewed
Apr 11, 2019
|
If the tests pass this should be good to go. The name change will be in a different PR. |
|
Updated the notebook after discovering a bug thanks to @ladoramkershner's comments. Error now at about +/- 0.01 lat/lon. |
jessemapel
reviewed
Apr 11, 2019
ale/drivers/kaguya_driver.py
Outdated
| @property | ||
| def _detector_center_line(self): | ||
| return 1 | ||
|
|
||
| @property | ||
| def _detector_center_sample(self): | ||
| return spice.gdpool('INS{}_CENTER'.format(self.ikid), 0, 2)[0] | ||
| return spice.gdpool('INS{}_CENTER'.format(spice.bods2c("LISM_TC2")), 0, 2)[0] |
There was a problem hiding this comment.
Does this work for TC1 images?
There was a problem hiding this comment.
That should be self._tc_id, fixed.
jessemapel
approved these changes
Apr 12, 2019
jessemapel
pushed a commit
to jessemapel/eal
that referenced
this pull request
May 30, 2022
* added Kaguya TC driver * addressed comments * forgot to import config * ijport glob * all the things * for some reason line_exposure_duration is a list, but only sometimes * updated Dawn with new bnames * better names for CTX Isis drivers(?) * renamed distortion * moved enter/exit logic back into the spice class * removed print statement * revert name change * tc_id -> _tc_id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should also address #94Notebook with demo https://gist.github.com/Kelvinrr/93614ea6b17d07faf7ebd294fd065a8e
Adds Kaguya TC distortion model but isn't being used by usgscsm, needs to be added there.