Initial switch to httr2 #738
Conversation
Merge branch 'main' of https://github.com/DOI-USGS/dataRetrieval into httr2 # Conflicts: # R/constructNWISURL.R # man/constructNWISURL.Rd
Merge branch 'main' of https://github.com/DOI-USGS/dataRetrieval into httr2 # Conflicts: # NEWS # R/getWebServiceData.R # man/getWebServiceData.Rd
|
@jesse-ross @ehinman @mikejohnson51 @dblodgett-usgs @mikemahoney218-usgs A fair number of tests were updated, but mostly it was URL attributes that the arguments got shifted around (so, same URL, different order). If any of you have any comments, feedback, questions, let me know. I think generally everything looks to be behaving the same, except for a few cases where we had non-200 results returning without error. At the moment, those cases now automatically error. Maybe that should be the case (I think a few of our old behaviors were mostly because the service would come back with useful information even though it was a 400 or something like that). Anyway, if it's a problem, we can add a tryCatch, but I kind of think this is a more expected behavior anyway. We're not planning an update to CRAN anytime soon. I expect this will stay in the "develop" branch for awhile. |
No description provided.