Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type hints added to public APIs of nwis module #122

Merged
merged 3 commits into from
Nov 24, 2023
Merged

Type hints added to public APIs of nwis module #122

merged 3 commits into from
Nov 24, 2023

Conversation

pkdash
Copy link
Contributor

@pkdash pkdash commented Nov 20, 2023 •
edited
Loading

Type hints added to all public functions of the nwis module.

@pkdash pkdash marked this pull request as ready for review November 20, 2023 22:28
thodson-usgs
thodson-usgs approved these changes Nov 24, 2023
View reviewed changes
Copy link
Collaborator

@thodson-usgs thodson-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent.
I plan to setup pre-commit to help with formatting. If you haven't used it, I can orient you.
And thank you for your contribution!

@thodson-usgs thodson-usgs merged commit 2747f0d into DOI-USGS:master Nov 24, 2023
10 checks passed
@pkdash pkdash deleted the 116-nwis-adding-type-hints branch December 1, 2023 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thodson-usgs thodson-usgs thodson-usgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pkdash @thodson-usgs