Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust code.json to point to new repo location #156

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

ehinman
Copy link
Collaborator

@ehinman ehinman commented Aug 30, 2024

To make the official release public again, we need to go through the Software Management official release process checklist. I believe we can use most of the info @thodson-usgs provided in 2023, but @ldecicco-USGS noticed that the code.json file still contains the outdated repo info. I have updated it in this PR. Once merged with master, I will sync it with GitLab and then make the exact same change to the tagged official release (v1.0.2). Does that sound good?

One question: should we change the metadataLastUpdated (line 42) date in the code.json file?

@ldecicco-USGS
Copy link
Collaborator

On the actual v1.0.2 tag, change line 7 to:
"status": "Production",

But otherwise those links look correct

@ldecicco-USGS
Copy link
Collaborator

You might be asked to do something like this:
https://code.usgs.gov/water/dataRetrieval/-/blob/main/code.json?ref_type=heads

on the tag - do it as you have done in this PR. Back on master, you can set it up so that it shows the production tag and the development master branch.

@thodson-usgs
Copy link
Collaborator

@ldecicco-USGS, this is one of the few cases where I might update GitLab first, make sure everything is kosher, then apply the change to GitHub. NBD, either way.

@ldecicco-USGS
Copy link
Collaborator

Yup, it's specifically a GitLab issue - I probably would too

Copy link
Collaborator

@thodson-usgs thodson-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve, though in these cases you may start on GitLab, make sure everything is working and approved there, then push the change back to this PR branch (or main if you're able).

@ehinman ehinman merged commit 16ab1de into DOI-USGS:master Aug 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants