-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add info about gwlevels service #160
Conversation
Is the information in the README correct? In separate conversations, I've been told the legacy profiles DO and DO NOT return new USGS data. |
Fine to occasionally use the README in this manner, but the principal source for this type of information should be the release notes. I would include your note there: https://github.com/DOI-USGS/dataretrieval-python/releases/v1.0.10 |
@thodson-usgs the legacy profiles do not include updated/new USGS discrete samples, but they DO include updated/new discrete samples from EPA/STORET. Also, we recently received an inquiry about the |
@ehinman the new warnings look good to me! I agree with @thodson-usgs that the updates to GWL should be in the auto-generated release notes, ideally we could modify those as needed so that they can be interpreted by users in a meaningful way. |
That's fine, and yes, many users don't, but you should always assume this to be the case and be wary of any package that doesn't.
Yes, you can edit them by clicking on the release (link above). I typically start with the auto-generated notes, then rewrite or expand as needed. |
Anything else I need to do for this PR? I think it's ready to merge. @thodson-usgs @lstanish-usgs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. thanks, @ehinman
more concise wording Co-authored-by: Timothy Hodson <[email protected]>
@ehinman looks good! Merge away |
Added a couple of sentences about the change to the
gwlevels
service in an attempt to catch/inform users that they need to update their version to leverage the new service.