Feature: General perimeter boundaries #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nnection cells are now always located along the edge of the perimeter with cell values == 1
…erpolate.griddata) to populate boundary cell values from the parent model solution, instead of mapping values on a cell-by-cell basis
…ion based perimeter heads through CHD package block
…thod to new ic module; * implement general 3d interpolation in ArraySourceData and MFBinarySourceData as alternative to having to manually specify layer mapping * major speedup of 3d interpoation in tmr.py by subsetting parent model and computing factors separately
…o scrub inactive bcs prior to write
…ve_bcs function; implement for MFnwtModel as well fix(interpolate.interp_weights): round barycentric weights, truncating floating point error so that the weights sum to 1. Weights not summing exactly to one seemed to be causing spurious values." tests: test suite passes. docs: still need to fill out section with description of CHD perimeter boundary input options.
…eriod_data cleaned by remove_inactive_bcs to external files for MF6 models where external files were specified
…imilar to how inflows are specified; refactor(MFsetupMixin.setup_sfr): consolidate flowline routing input
…regular_perimeter_boundary
…le global observation types
…ig file wasn't be used (default sfrmaker.Lines._original_routing was being used instead), which was leading to >50% of supplied runoff not being applied in shellmound test case (in the case of the Delta inset model ~75% of supplied runoff was being lost
… information; skip SFR_OBS package in checking for model equality since this input is handled by SFRmaker; a loaded model can have it (and a freshly made model not), with the models otherwise being the same
…where array of voxel cell edges has Nans
…generalize inflow test comid selection
…ete doctr deploy key
…mpty periods to turn off output writing
aleaf
force-pushed
the
feature_gen_perimeter
branch
from
d612612
to
c19e889
Compare
…mfnwt_inset): Flopy OC tuples are (kper, kstp), not (kstp, kper)
Codecov Report
@@ Coverage Diff @@
## develop #34 +/- ##
===========================================
- Coverage 86.13% 86.00% -0.13%
===========================================
Files 59 62 +3
Lines 10601 11369 +768
===========================================
+ Hits 9131 9778 +647
- Misses 1470 1591 +121
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalize perimeter boundary setup so that
Refactor configuration file input so that perimeter boundaries are set up through a
perimeter_boundary:sub-block within the block for a package.Currently, specified head perimeter boundaries are supported via the MODFLOW 6 Constant Head (CHD) Package; specified flux boundaries using the MODFLOW 6 Well (WEL) Package are still in active development. It is envisioned that specified flux perimeter cells will follow the same basic structure/conceptualization as specified heads.
Progress towards #25