feat(specified flux boundaries): implement general specified flux perimeter boundary #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor MF6model.setup_wel to follow same structure as other basic stress packages (use the _setup_basic_stress_package fn, which combines perimeter boundaries with user input and for the Well Package, potential input from a parent model) * implement general basic stress package support for MODFLOW-NWT models * move _setup_basic_stress_package to MFsetupMixin to use same workflow for both MODFLOW versions * TODO: get MODFLOW-NWT well package setup tests to pass; either adapt or remove any old tests related to specified flux boundaries * add specified flux perimeter boundary to the config file gallery for a working example * remove old Tmr class from tmr.py and any other kruft * update docs, including limitation that specified flux models must be co-linear
…MODFLOW-NWT models; generalize _setup_basic_stress_package method and move to MFsetupMixin class
…imeter boundary; add to Shellmound TMR example
Codecov Report
@@ Coverage Diff @@
## develop #45 +/- ##
===========================================
+ Coverage 86.37% 89.38% +3.01%
===========================================
Files 64 64
Lines 12514 11769 -745
===========================================
- Hits 10809 10520 -289
+ Misses 1705 1249 -456
Continue to review full report at Codecov.
|
…sions between lake and sfr packages; refactor: some more kruft removal aimed at boosting test coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements #25
addresses #15