Refactor obs setup #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor setup_head_observations to include inputs in signature (instead of buried in cfg dict attached to model object) and be closer to a stand-alone function. * added allow_obs_in_bc_cells option to allow observations in boundary condition cells (previously not allowed). * put modflow-setup specific options in mfsetup_options: block, consistent with other packages * TODO: setup_head_observations could probably be further refactored for consistency with other input by utilizing the TabularSourceData class
…ansform object from a flopy structured grid; this allows the rasterize() method to work with standard flopy StructuredGrid instances
… in IMS options (remap input to work with Flopy)
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## develop #69 +/- ##
========================================
Coverage 89.09% 89.10%
========================================
Files 64 64
Lines 12255 12271 +16
========================================
+ Hits 10919 10934 +15
- Misses 1336 1337 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor setup_head_observations to include inputs in signature and to more as a stand-alone function. Support regular Flopy StructuredGrids with rasterize() method. Support inner and outer CSV file output in IMS package.