Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MFsetupMixin.setup_sfr): properly handle revised SFRmaker assign_… #78

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

aleaf
Copy link
Collaborator

@aleaf aleaf commented Feb 15, 2024

…layers method that returns a 3D array of revised cell bottom elevations, when there are reaches that extend below the model bottom. In cases where there are multiple inactive layers below the lowest active cell, multiple bottom layer elevations will need to be revised.

…layers method that returns a 3D array of revised cell bottom elevations, when there are reaches that extend below the model bottom. In cases where there are multiple inactive layers below the lowest active cell, multiple bottom layer elevations will need to be revised.
@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6f434e9) 89.10% compared to head (161e2d0) 89.02%.

Files Patch % Lines
mfsetup/mfmodel.py 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #78      +/-   ##
===========================================
- Coverage    89.10%   89.02%   -0.08%     
===========================================
  Files           64       64              
  Lines        12401    12396       -5     
===========================================
- Hits         11050    11036      -14     
- Misses        1351     1360       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aleaf aleaf merged commit d2d459e into DOI-USGS:develop Feb 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants