Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for #94 -- normalized weights #96

Merged
merged 3 commits into from
Feb 3, 2024
Merged

for #94 -- normalized weights #96

merged 3 commits into from
Feb 3, 2024

Conversation

dblodgett-usgs
Copy link
Collaborator

No description provided.

@dblodgett-usgs dblodgett-usgs changed the title for #94 -- not right yet for #94 -- normalized weights Feb 3, 2024
@dblodgett-usgs
Copy link
Collaborator Author

Added the reprex shown in #94 to tests -- should be solid.

@dblodgett-usgs
Copy link
Collaborator Author

@elliewhite-usgs -- Can you try out the normalized weights in a workflow and see if this seems correct?

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f0808d3) 91.85% compared to head (88a1d13) 91.74%.
Report is 10 commits behind head on main.

❗ Current head 88a1d13 differs from pull request most recent head bf3da0a. Consider uploading reports for the commit bf3da0a to get more accurate results

Files Patch % Lines
R/calculate_area_intersection_weights.R 90.90% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
- Coverage   91.85%   91.74%   -0.11%     
==========================================
  Files          11       11              
  Lines         896      909      +13     
==========================================
+ Hits          823      834      +11     
- Misses         73       75       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dblodgett-usgs dblodgett-usgs merged commit 56fda75 into main Feb 3, 2024
1 check passed
@dblodgett-usgs dblodgett-usgs deleted the normalize_weights branch February 5, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants