Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle lowercase nhdplusid fixes #393 #394

Merged
merged 2 commits into from
Jul 20, 2024
Merged

handle lowercase nhdplusid fixes #393 #394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78829da
handle lowercase nhdplusid fixes #393
dblodgett-usgs Jul 20, 2024
ede3166
skip web service tests on ci
dblodgett-usgs Jul 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: nhdplusTools
Type: Package
Title: NHDPlus Tools
Version: 1.2.1
Version: 1.2.2
Authors@R: c(person(given = "David",
family = "Blodgett",
role = c("aut", "cre"),
Expand Down
2 changes: 1 addition & 1 deletion R/A_nhdplusTools.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ WBAREACOMI <- "WBAREACOMI"

# List of input names that should be changed to replacement names
nhdplus_attributes <- list(
COMID = COMID, NHDPlusID = COMID,
COMID = COMID, NHDPlusID = COMID, nhdplusid = COMID,
Permanent_Identifier = Permanent_Identifier,
RPUID = RPUID,
VPUID = VPUID,
Expand Down
1 change: 1 addition & 0 deletions tests/testthat/test_01_get_nldi.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ test_that("navigation works", {
test_that("basin works", {

skip_on_cran()
skip_on_ci()

nldi_nwis <- list(featureSource = "nwissite", featureID = "USGS-05428500")

Expand Down
Loading