scripts: fix double ME flashing dialog #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During attempt to update Dasharo via DTS user is asked twice to skip ME flashing. Move set_intel_regions_...() call from ..._updating_routine() to the "else" part of the "if" statement after ..._updating_routine() call so it is not executed twice. Signed-off-by: Mateusz Kusiak <[email protected]>
|
Needs to be tested on bare metal. |
|
I confirm the fix is working or bare metal. |
m-iwanicki
approved these changes
Feb 5, 2025
|
@artur-rs Can we ensure this check will go into automated test scenario? |
|
@macpijan sure, adding to the test-scope backlog |
|
@3mkusiak Could you please share the steps needed to reproduce the original problem in DTS? |
|
Prerequisites Reproduction scenario
Expected results Actual result |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During attempt to update Dasharo via DTS user is asked twice to skip ME flashing. Move
set_intel_regions_update_params()call fromfirmware_pre_updating_routine()to the "else" part of the "if" statement afterfirmware_pre_updating_routine()call so it is not executed twice.