dasharo-security/secure-boot.robot - UEFI Shell less SBO tests #725
+68
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
miczyg1
reviewed
Mar 14, 2025
dasharo-security/secure-boot.robot
Outdated
Comment on lines
141
to
147
| # {advanced_menu}= Enter Advanced Secure Boot Keys Management And Return Construction ${sb_menu} | ||
|
|
||
| # TBD: | ||
|
|
||
| # Enter Enroll DB Signature Using File In DB Options ${advanced_menu} | ||
| # Enter Volume In File Explorer GOOD_KEYS | ||
| # Select File In File Explorer DB.cer | ||
| # Save Changes And Reset | ||
| # Changes to Secure Boot menu take action immediately, so we can just reset |
There was a problem hiding this comment.
I am not sure if I should review further after seeing this commented code
matmacieje
force-pushed
the
SBO_shell_drop0000
branch
from
296ced2 to
47d96e1
Compare
Test cases SBO003.001, SBO004.001, SBO005.001, SBO007.001, SBO008.001 working without UEFI Shell dependency (100% setup menu based execution). USB stick image labeled BAD_INFLUE is now required, containing new hello_dasharo.efi test program, to enable serial port message capture. Signed-off-by: Mateusz Maciejewski <[email protected]>
matmacieje
force-pushed
the
SBO_shell_drop0000
branch
from
47d96e1 to
45b345b
Compare
|
Squashed & rebased to develop. |
miczyg1
requested changes
Mar 19, 2025
| @@ -263,3 +256,14 @@ Set Secure Boot State To Disabled | |||
| Disable Secure Boot ${sb_menu} | |||
| # Changes to Secure Boot menu take action immediately, so we can just reset | |||
| Tianocore Reset System | |||
|
|
|||
| Boot EFI Executable From The Drive | |||
There was a problem hiding this comment.
Why is it not a part of lib/secure-boot-lib.robot?
| @@ -182,10 +202,11 @@ Enter Volume In File Explorer | |||
| [Documentation] Enter the given volume | |||
| [Arguments] ${target_volume} | |||
| # 1. Read out the whole File Explorer menu | |||
| ${volumes}= Get Submenu Construction opt_only=${TRUE} | |||
| Sleep 1s | |||
There was a problem hiding this comment.
Why is the sleep needed? Get Submenu Construction should read everything util a checkpoint is found
Comment on lines
-28
to
-29
| ... Mount USB Disk Image ${TEST_DATA_DIR}/secure-boot/sb_test_data.img | ||
| ... AND |
There was a problem hiding this comment.
I believe we should not remove it. It used to mount an USB image via PiKVM with the same content as BAD_INFLUE to test Secure Boot. it should be possible to maintain the compatibility with PiKVM.
This reverts commit 64e2dd9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SBO003.001 & SBO004.001 - WiP.
lib/secure-boot-lib.robot keywords for setup menu Secure Boot testing platform-configs/include/default.robot - output strings expected by SBO tests in menu-based execution