Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IP Exclusivity protection (IP, RTE IP, Sonoff IP. PiKVM IP) #110

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

matmacieje
Copy link
Contributor

This change prevents invasive CLI operations if any of asset's IP related data field contains non-exclusive address.

@macpijan
Copy link
Contributor

Fixes: #27

CLI client-side mechanism, enforcing IP exclusivity in asset data
from Snipe-IT, covering system IP, RTE IP, Sonoff IP & PiKVM IP.
Throws DuplicatedIpException to prevent user from remote hardware
manipulation if duplicated IP entries exist.

Signed-off-by: Mateusz Maciejewski <[email protected]>
Bugfix for cases, when asset ID is retrieved from Snipe-IT data by
RTE IP or Sonoff IP.

Signed-off-by: Mateusz Maciejewski <[email protected]>
Test suite covering some possible use cases od IP exclusivity detection.
IP/ID fake DUT data in robot file must be kept in sync with Snipe-IT.
Added Check Out By Asset ID to common keywords.

Signed-off-by: Mateusz Maciejewski <[email protected]>
@macpijan macpijan force-pushed the ip_protection_fix002 branch from 573a473 to 75e6c3f Compare February 24, 2025 11:44
@macpijan macpijan merged commit 75e6c3f into main Feb 24, 2025
@macpijan macpijan deleted the ip_protection_fix002 branch February 24, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants