Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osfv_cli/src/osfv/cli/cli.py: add ad-hoc-mode #94

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

WiktorG351
Copy link

No description provided.

Copy link
Contributor

@PLangowski PLangowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@macpijan
Copy link
Contributor

if/how is it related to: https://github.com/Dasharo/osfv-scripts/pull/83/files ?

@WiktorG351
Copy link
Author

well it is related - I guess the same effect can be achieved by just using --skip-snipeit.
For example, in the original issue:

It would be useful to be able to use this script also ad-hoc, using any RTE, not only for devices in lab.

Currently it looks like this:

osfv_cli rte --rte_ip 192.168.4.64 --model 'MinnowBoard Turbot B41' flash probe  
No asset found with RTE IP: 192.168.4.64
DUT model retrieved from cmdline, skipping Snipe-IT query
Using rte command is invasive action, checking first if the device is not used...
Error checking out asset None
Response data: None
Exiting to avoid conflict. Check who is working on this device and contact them first.

we could just use --skip-snipeit to achieve what we want.
Is an ad-hoc-mode even needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants