TSPS-402 Update Successful Notification with user data TTL #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
January 27, 2025 17:21
|
Reminder to update the prod template after testing against my bee |
mmorgantaylor
approved these changes
Feb 3, 2025
|
|
||
|
|
||
| ## Updating Templates | ||
| Doc explaining the process for changes and how to test - https://docs.google.com/document/d/1e2UisAYbW9wXwyI7sWLtYMmX0ILWBP_lvRONBVEbliY/edit?tab=t.0 |
There was a problem hiding this comment.
thank you for adding a link to this documentation!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want our notification email to inform the user how much time they have before their data gets deleted.
Changes that are a part of this pr in other repos
workbench libs - broadinstitute/workbench-libs#1720 and broadinstitute/workbench-libs#1721
thurloe - broadinstitute/thurloe#375
Jira Ticket
https://broadworkbench.atlassian.net/browse/TSPS-402
Prod sendgrid template has been updated
This is the email i was sent after testing on my bee. This change actually wouldnt look any different than the original template so i have two pictures to prove it was actually working as intended with a screenshot of some intermediate work that got deleted after.
This is a screenshot when we were displaying the number of days in the table
This is a screenshot of the final version (this is gonna look the same as it was before any of these changes were made)