[APM] Add basic test for Client Side Stats #33577

ichinaski · 2025-01-30T12:42:26Z

What does this PR do?

Add basic test for Client Side Stats computation.

Motivation

Describe how you validated your changes

e2e tests

Possible Drawbacks / Trade-offs

Additional Notes

agent-platform-auto-pr · 2025-01-30T13:07:41Z

[Fast Unit Tests Report]

On pipeline 55900234 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

tests_deb-arm64-py3
tests_deb-x64-py3
tests_flavor_dogstatsd_deb-x64
tests_flavor_heroku_deb-x64
tests_flavor_iot_deb-x64
tests_rpm-arm64-py3
tests_rpm-x64-py3
tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

agent-platform-auto-pr · 2025-01-30T13:09:33Z

Uncompressed package size comparison

Comparison with ancestor dee20b3f6e0f9b836ca7fb54a580b54985412c47

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-amd64-deb	0.00MB	✅	865.93MB	865.93MB	0.50MB
datadog-agent-x86_64-rpm	0.00MB	✅	875.70MB	875.70MB	0.50MB
datadog-agent-x86_64-suse	0.00MB	✅	875.70MB	875.70MB	0.50MB
datadog-agent-arm64-deb	0.00MB	✅	854.43MB	854.43MB	0.50MB
datadog-agent-aarch64-rpm	0.00MB	✅	864.18MB	864.18MB	0.50MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	41.57MB	41.57MB	0.50MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	41.64MB	41.64MB	0.50MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	41.64MB	41.64MB	0.50MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	39.83MB	39.83MB	0.50MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	441.04MB	441.04MB	0.50MB
datadog-iot-agent-amd64-deb	0.00MB	✅	61.75MB	61.75MB	0.50MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	61.82MB	61.82MB	0.50MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	61.82MB	61.82MB	0.50MB
datadog-iot-agent-arm64-deb	0.00MB	✅	59.00MB	59.00MB	0.50MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	59.08MB	59.08MB	0.50MB

Decision

✅ Passed

agent-platform-auto-pr · 2025-01-30T13:11:30Z

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=55900234 --os-family=ubuntu

Note: This applies to commit 009cf68

cit-pr-commenter · 2025-01-30T13:33:38Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: a7af5eb8-ebc9-4205-9e6b-0343fdd419bc

Baseline: dee20b3
Comparison: 009cf68
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+2.74	[-0.41, +5.88]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.28	[-0.18, +0.74]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.21	[-0.68, +1.11]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.11	[-0.58, +0.79]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	+0.06	[-0.84, +0.95]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.03	[-0.77, +0.83]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.00	[-0.63, +0.63]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.03, +0.02]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.02	[-0.30, +0.25]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.04	[-0.93, +0.86]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.07	[-0.86, +0.71]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.10	[-0.16, -0.05]	1	Logs bounds checks dashboard
➖	quality_gate_idle	memory utilization	-0.14	[-0.18, -0.10]	1	Logs bounds checks dashboard
➖	file_tree	memory utilization	-0.24	[-0.31, -0.18]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.39	[-1.18, +0.39]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.46	[-0.53, -0.39]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

agent-platform-auto-pr · 2025-02-13T15:40:01Z

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result	Quality gate	On disk size	On disk size limit	On wire size	On wire size limit
✅	static_quality_gate_agent_deb_amd64	837.77MiB	847.49MiB	202.75MiB	212.83MiB
✅	static_quality_gate_agent_deb_arm64	826.72MiB	858.45MiB	182.99MiB	214.3MiB
✅	static_quality_gate_agent_rpm_amd64	837.76MiB	858.45MiB	206.16MiB	214.3MiB
✅	static_quality_gate_agent_rpm_arm64	826.67MiB	858.45MiB	184.46MiB	214.3MiB
✅	static_quality_gate_agent_suse_amd64	837.7MiB	858.45MiB	206.16MiB	214.3MiB
✅	static_quality_gate_agent_suse_arm64	826.72MiB	858.45MiB	184.46MiB	214.3MiB
✅	static_quality_gate_dogstatsd_deb_amd64	39.72MiB	49.7MiB	10.57MiB	20.6MiB
✅	static_quality_gate_dogstatsd_deb_arm64	38.06MiB	48.1MiB	9.14MiB	19.1MiB
✅	static_quality_gate_dogstatsd_rpm_amd64	39.72MiB	49.7MiB	10.58MiB	20.6MiB
✅	static_quality_gate_dogstatsd_suse_amd64	39.72MiB	49.7MiB	10.58MiB	20.6MiB
✅	static_quality_gate_iot_agent_deb_amd64	58.96MiB	69.0MiB	14.82MiB	24.8MiB
✅	static_quality_gate_iot_agent_deb_arm64	56.35MiB	66.4MiB	12.79MiB	22.8MiB
✅	static_quality_gate_iot_agent_rpm_amd64	58.96MiB	69.0MiB	14.84MiB	24.8MiB
✅	static_quality_gate_iot_agent_rpm_arm64	56.35MiB	66.4MiB	12.8MiB	22.8MiB
✅	static_quality_gate_iot_agent_suse_amd64	58.96MiB	69.0MiB	14.84MiB	24.8MiB
✅	static_quality_gate_docker_agent_amd64	921.98MiB	931.7MiB	308.75MiB	318.67MiB
✅	static_quality_gate_docker_agent_arm64	934.34MiB	944.08MiB	292.74MiB	303.0MiB
✅	static_quality_gate_docker_agent_jmx_amd64	1.09GiB	1.1GiB	383.85MiB	393.75MiB
✅	static_quality_gate_docker_agent_jmx_arm64	1.09GiB	1.1GiB	363.82MiB	373.71MiB
✅	static_quality_gate_docker_dogstatsd_amd64	47.86MiB	57.88MiB	18.3MiB	28.29MiB
✅	static_quality_gate_docker_dogstatsd_arm64	46.25MiB	56.27MiB	17.05MiB	27.06MiB
✅	static_quality_gate_docker_cluster_agent_amd64	267.76MiB	277.7MiB	107.31MiB	117.28MiB
✅	static_quality_gate_docker_cluster_agent_arm64	283.8MiB	293.73MiB	102.14MiB	112.12MiB

ajgajg1134

NICE! :D

test/new-e2e/tests/apm/docker_test.go

Co-authored-by: Andrew Glaude <[email protected]>

ichinaski · 2025-02-14T11:23:17Z

/merge

dd-devflow · 2025-02-14T11:23:22Z

View all feedbacks in Devflow UI.
2025-02-14 11:23:21 UTC ℹ️ Start processing command /merge

2025-02-14 11:23:24 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 33m.

2025-02-14 11:52:34 UTC ℹ️ MergeQueue: This merge request was merged

[APM] Add basic test for Client Side Stats

f4eb002

ichinaski requested a review from a team as a code owner January 30, 2025 12:42

github-actions bot added short review PR is simple enough to be reviewed quickly team/agent-apm trace-agent labels Jan 30, 2025

ichinaski added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests labels Jan 30, 2025

Merge branch 'main' into ichinaski/e2e-css

967a0c0

ajgajg1134 approved these changes Feb 13, 2025

View reviewed changes

test/new-e2e/tests/apm/docker_test.go Outdated Show resolved Hide resolved

Update test/new-e2e/tests/apm/docker_test.go

009cf68

Co-authored-by: Andrew Glaude <[email protected]>

dd-mergequeue bot merged commit 6c42fbc into main Feb 14, 2025
213 checks passed

dd-mergequeue bot deleted the ichinaski/e2e-css branch February 14, 2025 11:52

github-actions bot added this to the 7.64.0 milestone Feb 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[APM] Add basic test for Client Side Stats #33577

[APM] Add basic test for Client Side Stats #33577

ichinaski commented Jan 30, 2025

agent-platform-auto-pr bot commented Jan 30, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Jan 30, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Jan 30, 2025 •

edited

Loading

cit-pr-commenter bot commented Jan 30, 2025 •

edited

Loading

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

agent-platform-auto-pr bot commented Feb 13, 2025 •

edited

Loading

Info

ajgajg1134 left a comment

ichinaski commented Feb 14, 2025

dd-devflow bot commented Feb 14, 2025 •

edited

Loading

[APM] Add basic test for Client Side Stats #33577

[APM] Add basic test for Client Side Stats #33577

Conversation

ichinaski commented Jan 30, 2025

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

agent-platform-auto-pr bot commented Jan 30, 2025 • edited Loading

agent-platform-auto-pr bot commented Jan 30, 2025 • edited Loading

Uncompressed package size comparison

Decision

agent-platform-auto-pr bot commented Jan 30, 2025 • edited Loading

Test changes on VM

cit-pr-commenter bot commented Jan 30, 2025 • edited Loading

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

agent-platform-auto-pr bot commented Feb 13, 2025 • edited Loading

Static quality checks ✅

Info

ajgajg1134 left a comment

Choose a reason for hiding this comment

ichinaski commented Feb 14, 2025

dd-devflow bot commented Feb 14, 2025 • edited Loading

agent-platform-auto-pr bot commented Jan 30, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Jan 30, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Jan 30, 2025 •

edited

Loading

cit-pr-commenter bot commented Jan 30, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 13, 2025 •

edited

Loading

dd-devflow bot commented Feb 14, 2025 •

edited

Loading