-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: pin github actions by hash and update via dependabot #3146
Conversation
BenchmarksBenchmark execution time: 2025-02-05 14:35:35 Comparing candidate commit 2fb957d in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks you for identifying the issue, providing a solution, and taking care of reducing future maintenance burden on the engineers working in this repository 🙇.
53b871b
to
c770bc3
Compare
Datadog ReportBranch report: ✅ 0 Failed, 5222 Passed, 72 Skipped, 1m 57.76s Total Time |
c155acc
to
c770bc3
Compare
c770bc3
to
92818db
Compare
What does this PR do?
Motivation
Pinning 3rd-party GitHub Actions by commit SHA makes them less vulnerable to compromise of the 3rd party. To avoid outdating and non-verbosity, versions are commented after the SHA and updating via dependabot is introduced that will automatically update the commented version tag as well.
In case of a false commit SHA, this change could break the corresponding workflow. Typically, this does not cause major interruptions, but it can for example affect a release pipeline and require restart causing delays.
Reviewer's Checklist
v2-dev
branch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!