Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): remove span from ExecutionContext #12248

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Feb 6, 2025

This PR removes the deprecated span attribute from ddtrace.internal.core.ExecutionContext(...). With this change the core execution execution context will be product agnostic.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Feb 6, 2025

CODEOWNERS have been resolved as:

ddtrace/_trace/trace_handlers.py                                        @DataDog/apm-sdk-api-python
ddtrace/appsec/_asm_request_context.py                                  @DataDog/asm-python
ddtrace/appsec/_processor.py                                            @DataDog/asm-python
ddtrace/contrib/internal/trace_utils.py                                 @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/internal/core/__init__.py                                       @DataDog/apm-core-python
tests/appsec/appsec/test_processor.py                                   @DataDog/asm-python
tests/appsec/appsec/test_remoteconfiguration.py                         @DataDog/asm-python
tests/appsec/contrib_appsec/utils.py                                    @DataDog/asm-python
tests/appsec/integrations/flask_tests/test_appsec_flask_telemetry.py    @DataDog/asm-python
tests/contrib/asyncio/test_tracer.py                                    @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/djangorestframework/test_appsec.py                        @DataDog/asm-python
tests/tracer/test_trace_utils.py                                        @DataDog/apm-sdk-api-python
tests/tracer/test_tracer.py                                             @DataDog/apm-sdk-api-python

@pr-commenter
Copy link

pr-commenter bot commented Feb 6, 2025

Benchmarks

Benchmark execution time: 2025-02-10 21:29:52

Comparing candidate commit c01f0e4 in PR branch munir/remove-span-from-core-api with baseline commit 1247ac2 in branch main.

Found 4 performance improvements and 0 performance regressions! Performance is the same for 390 metrics, 2 unstable metrics.

scenario:coreapiscenario-context_with_data_no_listeners

  • 🟩 execution_time [-443.004ns; -372.011ns] or [-9.518%; -7.993%]

scenario:coreapiscenario-get_item_exists

  • 🟩 execution_time [-134.298ns; -125.530ns] or [-19.571%; -18.293%]

scenario:coreapiscenario-get_item_missing

  • 🟩 execution_time [-133.397ns; -124.935ns] or [-18.259%; -17.101%]

scenario:iast_aspects-bytesio_aspect

  • 🟩 execution_time [-197.317ns; -170.487ns] or [-8.264%; -7.140%]

@mabdinur mabdinur changed the title chore(core): span from ExecutionContext chore(core): remove span from ExecutionContext Feb 6, 2025
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Feb 10, 2025

Datadog Report

Branch report: munir/remove-span-from-core-api
Commit report: c01f0e4
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1184 Skipped, 3m 25.61s Total duration (26m 1.43s time saved)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant