Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled HA Support #19765

Merged
merged 5 commits into from
Mar 6, 2025
Merged

Enabled HA Support #19765

merged 5 commits into from
Mar 6, 2025

Conversation

AlexandreYang
Copy link
Member

@AlexandreYang AlexandreYang commented Mar 5, 2025

What does this PR do?

Enabled HA Support

Agent PR for QA: DataDog/datadog-agent#34769

✅ Already QAed

image

Motivation

User can run http_check in HA mode.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.97%. Comparing base (6cae367) to head (59cdc10).
Report is 2 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
http_check 94.26% <100.00%> (+<0.01%) ⬆️
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AlexandreYang AlexandreYang added the qa/skip-qa Automatically skip this PR for the next QA label Mar 6, 2025
@@ -0,0 +1 @@
Enabled HA Support
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The target audience for the changelogs is customers/users. Imagine you're a customer/user. Do you understand this entry? ;)

@AlexandreYang AlexandreYang requested a review from iliakur March 6, 2025 09:58
Copy link
Contributor

@iliakur iliakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@AlexandreYang AlexandreYang added this pull request to the merge queue Mar 6, 2025
Merged via the queue into master with commit 9e6db48 Mar 6, 2025
41 of 42 checks passed
@AlexandreYang AlexandreYang deleted the alex/ha_http_check branch March 6, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants