-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable ASGCT by default on fairly safe J9 JDK versions #181
Open
jbachorik
wants to merge
1
commit into
main
Choose a base branch
from
jb/j9_versions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔧 Report generated by pr-comment-scanbuild Scan-Build Report
Bug Summary
Reports
|
d308929
to
0f904ce
Compare
ac1fb68
to
6880d41
Compare
6880d41
to
c8e0e50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
It updates the 'safe' versions for J9 usage of ASGCT.
These versions have been tested and are behaving correctly.
Motivation:
The JVMTI based sampler is causing a noticeable overhead. Being able to use ASGCT where it is fairly safe will make the usage of profiler much nicer experience.
Additional Notes:
This change is adding support for forcing the 'jvmti' samplers by setting system property
dd.profiling.ddprof.j9.sampler=jvmti
How to test the change?:
Added sanity tests which will be executed when running on J9 JVMs
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!