chore(nginx): support nginx 1.27.4 and 1.26.3 #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmehala
requested review from
zacharycmontoya,
dubloom and
pablomartinezbernardo
and removed request for
a team
|
Looks like it's still having some issues with the python packages |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #169 +/- ##
=======================================
Coverage 71.87% 71.87%
=======================================
Files 44 44
Lines 6190 6190
Branches 899 899
=======================================
Hits 4449 4449
Misses 1305 1305
Partials 436 436 |
pablomartinezbernardo
approved these changes
Feb 7, 2025
| @@ -287,7 +287,7 @@ jobs: | |||
| command: git clone https://github.com/DataDog/system-tests.git | |||
| name: clone system-tests repo | |||
| - run: | |||
| command: sudo apt-get install python3.12-venv | |||
| command: "sudo apt update -y \nsudo apt install -y python3.12-venv\n" | |||
There was a problem hiding this comment.
nit: Can we use && instead of \n?
|
Will these matching tarballs be added to the v1.5.0 release? Or will this be a 1.5.1? |
|
Will be |
|
@Xanotis I updated Tracing onlyTracing + Appsec |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.