Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shrink block cache size for saluki/dsd_uds_100mb_250k_contexts experiment to avoid OOM #462

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

tobz
Copy link
Member

@tobz tobz commented Jan 30, 2025

Summary

This PR is trying to fix both the fact that the Saluki variant of the dsd_uds_100mb_250k_contexts hits OOM issues with its lading configuration due to recent SMP runner changes... and the fact that the lading configuration only seems to end up generating ~160-170k contexts.

This should hopefully solve both and lead to around ~215k contexts being generated while still fitting within the new limits imposed on SMP runners.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

How did you test this PR?

N/A

References

N/A

@tobz tobz requested a review from a team as a code owner January 30, 2025 01:16
@github-actions github-actions bot added the area/ci CI/CD, automated testing, etc. label Jan 30, 2025
@tobz tobz changed the title Tobz/tweak 250k context experiment new 2gb limit fix: shrink block cache size for saluki/dsd_uds_100mb_250k_contexts experiment to avoid OOM Jan 30, 2025
@pr-commenter
Copy link

pr-commenter bot commented Jan 30, 2025

Regression Detector (DogStatsD)

Regression Detector Results

Run ID: 00745a96-51a0-4ce6-8d99-80d57904c828

Baseline: 7.63.0-rc.2
Comparison: 7.63.0-rc.2

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
dsd_uds_100mb_3k_contexts_distributions_only memory utilization +1.64 [+1.49, +1.80] 1
quality_gates_idle_rss memory utilization +1.63 [+1.54, +1.72] 1
dsd_uds_512kb_3k_contexts ingress throughput +0.00 [-0.01, +0.01] 1
dsd_uds_1mb_50k_contexts ingress throughput +0.00 [-0.00, +0.00] 1
dsd_uds_1mb_3k_contexts ingress throughput +0.00 [-0.00, +0.00] 1
dsd_uds_100mb_250k_contexts ingress throughput +0.00 [-0.00, +0.00] 1
dsd_uds_1mb_3k_contexts_dualship ingress throughput -0.00 [-0.00, +0.00] 1
dsd_uds_1mb_50k_contexts_memlimit ingress throughput -0.00 [-0.00, +0.00] 1
dsd_uds_40mb_12k_contexts_40_senders ingress throughput -0.00 [-0.01, +0.00] 1
dsd_uds_100mb_3k_contexts ingress throughput -0.00 [-0.05, +0.04] 1
dsd_uds_10mb_3k_contexts ingress throughput -0.01 [-0.02, +0.01] 1
dsd_uds_500mb_3k_contexts ingress throughput -1.33 [-1.45, -1.21] 1

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
quality_gates_idle_rss memory_usage 0/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@pr-commenter
Copy link

pr-commenter bot commented Jan 30, 2025

Regression Detector (Saluki)

Regression Detector Results

Run ID: 0ee3ba13-997d-41e7-93b5-66b5820d2b01

Baseline: 96693fa
Comparison: bf42b9e
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
dsd_uds_1mb_50k_contexts_memlimit ingress throughput +0.73 [+0.20, +1.26] 1
dsd_uds_100mb_3k_contexts_distributions_only memory utilization +0.68 [+0.56, +0.81] 1
quality_gates_idle_rss memory utilization +0.25 [+0.22, +0.28] 1
dsd_uds_50mb_10k_contexts_no_inlining_no_allocs ingress throughput +0.02 [-0.04, +0.07] 1
dsd_uds_50mb_10k_contexts_no_inlining ingress throughput +0.02 [-0.05, +0.08] 1
dsd_uds_40mb_12k_contexts_40_senders ingress throughput +0.01 [-0.02, +0.03] 1
dsd_uds_512kb_3k_contexts ingress throughput +0.00 [-0.01, +0.01] 1
dsd_uds_1mb_50k_contexts ingress throughput -0.00 [-0.00, +0.00] 1
dsd_uds_1mb_3k_contexts ingress throughput -0.00 [-0.01, +0.00] 1
dsd_uds_1mb_3k_contexts_dualship ingress throughput -0.00 [-0.02, +0.01] 1
dsd_uds_100mb_3k_contexts ingress throughput -0.01 [-0.05, +0.04] 1
dsd_uds_10mb_3k_contexts ingress throughput -0.01 [-0.04, +0.03] 1
dsd_uds_100mb_250k_contexts ingress throughput -0.01 [-0.05, +0.03] 1
dsd_uds_500mb_3k_contexts ingress throughput -0.18 [-0.31, -0.06] 1

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
quality_gates_idle_rss memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@pr-commenter
Copy link

pr-commenter bot commented Jan 30, 2025

Regression Detector Links

Experiment Result Links

experiment link(s)
dsd_uds_100mb_250k_contexts [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_100mb_3k_contexts [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_100mb_3k_contexts_distributions_only [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_10mb_3k_contexts [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_1mb_3k_contexts [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_1mb_3k_contexts_dualship [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_1mb_50k_contexts [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_1mb_50k_contexts_memlimit [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_40mb_12k_contexts_40_senders [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_500mb_3k_contexts [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_512kb_3k_contexts [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
quality_gates_idle_rss [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_50mb_10k_contexts_no_inlining (ADP only) [Profiling (ADP)] [SMP Dashboard]
dsd_uds_50mb_10k_contexts_no_inlining_no_allocs (ADP only) [Profiling (ADP)] [SMP Dashboard]

@tobz tobz merged commit d544053 into main Feb 3, 2025
21 checks passed
@tobz tobz deleted the tobz/tweak-250k-context-experiment-new-2gb-limit branch February 3, 2025 18:31
@GeorgeHahn GeorgeHahn mentioned this pull request Mar 6, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci CI/CD, automated testing, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants