Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Customers Model: Convert CTEs into Intermediate Models #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

even-wei
Copy link
Collaborator

Overview:
Refactored the customers model by turning two CTEs into intermediate models, enhancing readability and maintainability.

Changes:

  • Created two new intermediate models from existing CTEs.
  • Updated customers model to integrate these models.
  • Conducted code cleanup for efficiency.

Rationale:
Improves clarity and allows easier future modifications.

Testing:
Ensured accuracy and consistency in results post-refactor.

Review Request:
Feedback on the implementation and integration of the new models is welcomed.

@kentwelcome kentwelcome force-pushed the refactor/customers-cte-to-models branch from 989057f to 21de9d2 Compare March 28, 2024 08:45
@kentwelcome kentwelcome force-pushed the refactor/customers-cte-to-models branch from 21de9d2 to a48228a Compare April 26, 2024 08:53

This comment was marked as outdated.

@DataRecce DataRecce deleted a comment from github-actions bot Apr 26, 2024
@popcornylu popcornylu force-pushed the refactor/customers-cte-to-models branch from a48228a to 24411d3 Compare May 29, 2024 06:02
Copy link

Recce Summary

Lineage Graph

graph LR
model.jaffle_shop.customers["customers

[What's Changed]
Code"]
style model.jaffle_shop.customers stroke:#ffa502
model.jaffle_shop.customers---->model.jaffle_shop.customer_segments
model.jaffle_shop.customers---->model.jaffle_shop.customer_order_pattern
model.jaffle_shop.customer_segments["customer_segments"]
model.jaffle_shop.customer_order_pattern["customer_order_pattern"]

Loading

Checks Summary

Checks Run Data Mismatch Detected
5 0

Next Steps

If you want to check more detail inforamtion about the recce result, please download the artifact file and open it by Recce CLI.

How to check the recce result

# Unzip the downloaded artifact file
tar -xf recce-state-file.zip

# Launch the recce server based on the state file
recce server --review recce_state.json

# Open the recce server http://localhost:8000 by your browser

@popcornylu popcornylu force-pushed the refactor/customers-cte-to-models branch from 24411d3 to e639327 Compare May 30, 2024 09:52
Copy link

Recce Summary

Lineage Graph

graph LR
model.jaffle_shop.customers["customers

[What's Changed]
Code"]
style model.jaffle_shop.customers stroke:#ffa502
model.jaffle_shop.customers---->model.jaffle_shop.customer_segments
model.jaffle_shop.customers---->model.jaffle_shop.customer_order_pattern
model.jaffle_shop.customer_segments["customer_segments"]
model.jaffle_shop.customer_order_pattern["customer_order_pattern"]

Loading

Checks Summary

Checks Run Data Mismatch Detected
5 0

Next Steps

If you want to check more detail inforamtion about the recce result, please download the artifact file and open it by Recce CLI.

How to check the recce result

# Unzip the downloaded artifact file
tar -xf recce-state-file.zip

# Launch the recce server based on the state file
recce server --review recce_state.json

# Open the recce server http://localhost:8000 by your browser

@popcornylu popcornylu force-pushed the refactor/customers-cte-to-models branch from e639327 to 0b8e642 Compare June 5, 2024 08:22
Copy link

github-actions bot commented Jun 5, 2024

Recce Summary

Lineage Graph

graph LR
model.jaffle_shop.customers["customers

[What's Changed]
Code"]
style model.jaffle_shop.customers stroke:#ffa502
model.jaffle_shop.customers---->model.jaffle_shop.customer_order_pattern
model.jaffle_shop.customers---->model.jaffle_shop.customer_segments
model.jaffle_shop.customer_order_pattern["customer_order_pattern"]
model.jaffle_shop.customer_segments["customer_segments"]

Loading

Checks Summary

Checks Run Data Mismatch Detected
4 2

Checks of Data Mismatch Detected

Name Type Mismatched Nodes
Model schema of customers, orders and modified nodes Schema Diff int_customer_orders, int_customer_payments, and 2 more nodes
Row count of customers, orders and modified table model Row Count Diff int_customer_orders, int_customer_payments, and 2 more nodes

How to check the recce result

# Launch the recce server based on the state file
recce server --review --cloud --password yummy_jaffle

# Open the recce server http://localhost:8000 by your browser

@kentwelcome kentwelcome force-pushed the refactor/customers-cte-to-models branch 2 times, most recently from 0a2188b to a4dd026 Compare June 6, 2024 18:30
@wcchang1115 wcchang1115 force-pushed the refactor/customers-cte-to-models branch 2 times, most recently from 4509780 to 4248a98 Compare June 20, 2024 03:44
@wcchang1115 wcchang1115 force-pushed the refactor/customers-cte-to-models branch from 4248a98 to e4ee394 Compare July 4, 2024 10:31
@kentwelcome kentwelcome force-pushed the refactor/customers-cte-to-models branch from e4ee394 to e23db56 Compare July 9, 2024 07:29
@wcchang1115 wcchang1115 force-pushed the refactor/customers-cte-to-models branch from e23db56 to e4ee394 Compare August 14, 2024 02:01
@kentwelcome kentwelcome force-pushed the refactor/customers-cte-to-models branch from e4ee394 to 6d4ed11 Compare September 20, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant