Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model type sbm_gwf: limit river flux to groundwater #549

Merged
merged 5 commits into from
Feb 13, 2025

Conversation

vers-w
Copy link
Collaborator

@vers-w vers-w commented Feb 11, 2025

Fixes #543

For `River` boundary of `GroundwaterFlow`.
Based on river storage. Additionally, the check of flux from an unconfined aquifer to a boundary condition is now based on the aquifer storage.
@vers-w vers-w marked this pull request as ready for review February 12, 2025 10:03
@vers-w vers-w requested a review from JoostBuitink February 12, 2025 10:04
Copy link
Contributor

@JoostBuitink JoostBuitink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just one comment related to the units of the infiltration_conductance.

@vers-w vers-w merged commit ac8164f into master Feb 13, 2025
9 checks passed
@vers-w vers-w deleted the sbm_gwf_river_flux branch February 13, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model type sbm_gwf: limit river flux to groundwater
2 participants