Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(member): implement member banners #1204

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

feat(member): implement member banners #1204

wants to merge 8 commits into from
+34 −0

Conversation

Snipy7374
Copy link
Contributor

Summary

Note that this is still untested as the feature is not rolled out yet.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added t: enhancement New feature t: api support Support of Discord API features s: waiting for api/docs Issue/PR is waiting for API support/documentation labels Jul 18, 2024
@shiftinv shiftinv added this to the disnake v2.10 milestone Jul 18, 2024
shiftinv
shiftinv reviewed Jul 21, 2024
View reviewed changes
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than those two comments, looks good to me! seems pretty straightforward.

disnake/member.py Show resolved Hide resolved
disnake/member.py Show resolved Hide resolved
shiftinv
shiftinv approved these changes Jul 21, 2024
View reviewed changes
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

disnake/member.py Outdated Show resolved Hide resolved
@Snipy7374 @shiftinv
Update disnake/member.py
1054c4b 
Co-authored-by: shiftinv <[email protected]>
Signed-off-by: Snipy7374 <[email protected]>
@Snipy7374
Copy link
Contributor Author

The "waiting for api docs" label can now be remoed 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiftinv shiftinv Awaiting requested review from shiftinv

@onerandomusername onerandomusername Awaiting requested review from onerandomusername

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
s: waiting for api/docs Issue/PR is waiting for API support/documentation t: api support Support of Discord API features t: enhancement New feature
Projects
disnake
Status: In Progress
Milestone
disnake v2.10
Development

Successfully merging this pull request may close these issues.

add support for member banners
3 participants
@Snipy7374 @shiftinv @onerandomusername