Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call _validate_steps in test_validate_steps #1307

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions tests/test_pipeline.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def test_validate_steps(self):
("bad", Thing()),
("model", MockEstimator()),
]
)
)._validate_steps()

# validate a bad intermediate transformer on the VisualPipeline
with pytest.raises(TypeError):
Expand All @@ -102,15 +102,17 @@ def test_validate_steps(self):
("bad", Thing()),
("model", MockEstimator()),
]
)
)._validate_steps()

# validate a bad final estimator on the Pipeline
with pytest.raises(TypeError):
Pipeline([("real", MockTransformer()), ("bad", Thing())])
Pipeline([("real", MockTransformer()), ("bad", Thing())])._validate_steps()

# validate a bad final estimator on the VisualPipeline
with pytest.raises(TypeError):
VisualPipeline([("real", MockTransformer()), ("bad", Thing())])
VisualPipeline(
[("real", MockTransformer()), ("bad", Thing())]
)._validate_steps()

# validate visual transformers on a Pipeline
try:
Expand Down