Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fuction usage to reference scikit-learn instead of pd.get_dummies #1321

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

bkp5190
Copy link

@bkp5190 bkp5190 commented Jan 18, 2025

This PR fixes a bug in the docs for validation curves where it references pd.get_dummies for one-hot encoding, but scikit-learn's OneHotEncoder function is used instead.

I have made the following changes:

  1. Update the documentation to show the correct function being used for one-hot encoding

Questions for the @DistrictDataLabs/team-oz-maintainers:

  • Do the docs still convey the same message

CHECKLIST

  • Is the commit message formatted correctly?
  • Have you noted the new functionality/bugfix in the release notes of the next release?
  • Have you built the docs using make html (must be run from docs/)?
    See below for the updated location render

@bkp5190
Copy link
Author

bkp5190 commented Jan 18, 2025

Screenshot 2025-01-18 at 9 53 41 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant