Improve zero downtime (healthcheck) and rollback documentation #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nktnet1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Siumauricio improved documentations for zero-downtime.
I ran into a lot of issues with this for a Dockerfile-based deployment using NextJS - it was difficult to debug due to limited logging available for healthchecks.
The main issues were:
curlis not installed in alphine-based images (only wget is available by default)HOSTNAMEenvironment variable to0.0.0.0localhostcommand used inwget/curlwas resolving to::1(IPv6 loopback) instead of 127.0.0.1 (IPv4), resulting in 404.I've updated the documentations for now, but some logging for the healthcheck, or even an icon/indicator to differentiate between healthy vs perpetually restarting, would be helpful.