Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡ Replaced pager with infinite loop (using react-virtualize) #554

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

ole1986
Copy link
Contributor

@ole1986 ole1986 commented Jun 5, 2020

WARNING: This is a very early PR and need more attention before merging

This PR contain the following changes:

  • Replaced pager with react-virtualized incl. AutoSizer and InfiteLoop while using List (source example)
  • Rewritten BranchGraph to make compatible with InfiniteLoop (@DonJayamanne I am no expert in this, so feel free to double check)
  • Future support for repository state change events being passed to browser app (registered through ResultActions.onStateChanged) - see browser/src/containers/App/index.tsx (not yet in use)

Known issues

  • BranchGraph does not seem to correctly parse merges from other branches when using "all branches"
  • Search has not fully tested after changing to react-virtualized
  • BranchGraph does not meet all previous changes (E.g. rounded corners)
  • Repository State event is triggered to often (due to git commands being called through exec) to use it properly
  • Graph is not correctly positioned when scrolling per pixel
  • File History is showing branch graph (which should be disabled)

InfiniteLoop in action

gitHistory-InfinteLoop

@DonJayamanne
Copy link
Owner

Will check this weekend, apologies for the delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants