Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: select flash on safari (ARM Platform) #2240

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

pointhalo
Copy link
Collaborator

@pointhalo pointhalo commented May 16, 2024

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Try to fix #1698 #2228

修改思路:在select init时,会调用 collectOptions,这里会更新一次 Popover的 props.rePosKey ,将init中的调用改为false。因为后续 open时依然会调 rePosKey更新

Changelog

🇨🇳 Chinese


🇺🇸 English

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

cypress bot commented May 16, 2024

1 failed test on run #2493 ↗︎

1 258 10 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 8937586 into 75eb456...
Project: semi-design Commit: e54e545027 ℹ️
Status: Failed Duration: 11:13 💡
Started: May 16, 2024 3:12 AM Ended: May 16, 2024 3:23 AM

Review all test suite changes for PR #2240 ↗︎

@pointhalo
Copy link
Collaborator Author

pointhalo commented May 17, 2024

暂不合入。单测有fail case。
影响了受控场景下的onChange,很诡异。

@pointhalo
Copy link
Collaborator Author

image

@DaiQiangReal
Copy link
Collaborator

现在在 m3 上没复现

@pointhalo
Copy link
Collaborator Author

现在在 m3 上没复现

你指的是闪烁没复现,还是单测fail没复现?是前者吧?

@linpan
Copy link

linpan commented Jul 12, 2024

@DaiQiangReal 工作很认真。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Safari 浏览器下,Select 组件下拉框闪烁
4 participants