Fix for missing LEDs #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is in the Gray area of being useful for a tool-changer, but does not directly related to the tool-changing. Thus, it has been moved to the usermods directory. Further consideration is needed as for how to expose it as an option for the user to install.
Add config_switch.py
…k your filament if you want to
Fixed typo/grammar in install.sh
Updated output of probe calibration to give easier to read/copy output.
|
but silently ignoring might not be optimal either as the user will have no idea why it's not working if it should. I'll have to think about this one, there has to be a better solution. |
|
I think this solution is better. Added a
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found an issue where if you were missing a category of LEDs (Nozzle or Logo) an error would be thrown when attempting to set those LEDs. This was not allowing tool changes to happen.
Added some protection around the setting those LEDs when the
nozzle_led_name,logo_led_name, or `_led_name is not defined in the tool vars.I only have a single logo LED and no nozzle LEDs per tool. It seems this scenario can happen if you have one set of LEDs but not the other.