-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require zerogc #4
Draft
Techcable
wants to merge
14
commits into
master
Choose a base branch
from
require-zerogc
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't work becuase of const-fn limitations
Benefits: 1. Support GcDeserialize 2. Support heap-allocated type information Downsides: 1. Requires zerogc, which is a pretty big dependency :( Because of the relative instability of zerogc, I'm keeping this in a seperate branch... It is possible I may decide to merge it into master (especially if zerogc starts to stabilize some more)
This is why I need to always `cargo test --workspace` :p
Fix strange Id: Serialize bounds Add Serialize/GcDeserialize impl for FunctionDeclaration
Gc now implements Deref<Target=T> instead of Deref<Target=&'gc T>
Tests are a little broken (but mostly the expected code and #[reflect_func]
Also fixes #[reflect_func] attribute
It's just an ugly hack because I can't get lifetime variance to work -_-
Add a test to prevent this from regressing...
4b5915b
to
55b0936
Compare
This adds in commit 55b0936 (essentially the removal of the const_panic feature)
Also remove #[feature(const_raw_ptr_deref)]
Do not want to rely on zerogc here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benefits:
Downsides:
Requiring this will make it much harder to use outside of my compiler....
Because of the relative instability of zerogc, I'm going to keep this in a branch for now.
It is possible if I merge this if zerogc starts to stabilize and gains wider acceptance.....