WIP: Dependency, Rails, and Ruby upgrade main branch #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade Ruby: 3.0 -> 3.3.5
Upgrade to rails 7
Upgrade Sentry
Misc modernization
Fix asset pipeline + image handling
Fix asset precompilation
Since we intend to send exception, trace, and breadcrumb info to a third-party Sentry, we now need to scrub potentially sensitive info before sending. This commit attempts to remove where we've seen it, including: * from where we were intentionally sending addtiional data with exceptions * removing from breadcrumbs and traces via the Rails filter_parameters, which uses regexes to filter data from appearing in logs * dropping query params from the path in action-controller breadcrumbs, since it was showing get params that could reveal address information. More might be needed
Scrub potentially sensitive info before sending to Sentry
Sentry gems automatically apply filter_parameters as of 5.21 (was a bug - getsentry/sentry-ruby#2438) so we no longer need to do it ourselves. This also correctly scrubs the query params from path in action controller breadcrumbs, which was previously allowing sensitive data through. Lastly, it more specifically targets some filtered items to prevent unintended filtering of the congress message campaign ID. Tested locally.
Sentry scrubbing updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just opening this so we can track the diff a bit better between
masterand what's been merged into the upgrade branch.When we merge this it'd also be a good opportunity to switch from
mastertomainas the main branch!